Magi Hold QA

[Jakkal]

We've recently gotten some reports that Magi Hold is no longer working right. I'll be going through all the quests and NPCs and updating them.
Note: This is for the low level content only, not the 50+ stuff. We'll get to that later.

I'm going to go in order of the quests as they are listed in the database. (Though I've had to go a little bit out of order what with these "do all these other quests for this quest" quests.)

Quests:
Martok Outrigger Amulets - Removed Prereq. Updated with new loot handling code. Updated scripts on related mobs.
The Sick Recruit - Removed Prereq. Actually put in objectives as they were all missing. Put in checks for the related quests in case the player already did them, or they have to abandon this one for some reason. The rewards for this have the wrong classes and only the Channeler (Sorc) and Apostle (Monk) are available. This needs to be fixed in the future.
Defend the House of Shaof- Updated objectives to match data from live. Put in checks for the related quests in case the player already did them, or they have to abandon this one for some reason. The rewards for this have the wrong classes and only the Channeler (Sorc), Defiler (BM), and Apostle (Monk) are available. This needs to be fixed in the future.
The Hills Are Alive - Updated to current standards. Edited objectives to match data from live.

9/29/19
How (Not) To Impress The Masters - Updated to current standards. Removed Pre-Req (Unsure if it was necessary). Updated with new loot handling code.
Gathering the Cure - Redid everything from scratch.
The Cure - Redid everything from scratch.
Objects For Study - I worked on this earlier in the year and only had to make minor changes in relation to "Defend the House of Shaof"

9/30/19
Onward to Pao Min - Removed unnecessary objective. Updated to current standards.
Savagery Must Be Contained - Removed unnecesary Pre-req. Edited objectives to match data from live. Updated to current standards.
Impress the Commander - Redid everything from scratch.
Proving Your Worth - Redid everything from scratch. Using new loot handling code.
Cleaning Up - Updated to current standards. Edited objectives to match data from live.
Pride of the Army - This one is more complicated than it looks and I don't like the way it's currently set up. So I've set it so it can't be taken right now. Unfortunately I don't have anymore time to work on these tonight.

10/26/19
Pride of the Army - Revisiting this one from so long ago. We only have two ways we can set up mob spawns for quests like this, and neither one is very good for ambusher style quests. I'm going to leave this one as is (save removing an ambusher) until we're able to do events per group and not per player. For now, it should work fine, but you'll get an ambusher for everyone individual on the quest, so you could get up to 6 spawns for your group.
Short Handed Nakai - Complete. Updated scripts to current standards. Edited objective to match data from live.
Kill the Coward - Complete. Updated the scripts involved.
A Soldier's Job - Complete.

NPCS:

I set up all of the NPCs with their hail text in the Nakai Dojo, including the trainers, the merchants and the unnamed NPCs. I also fixed the questgiver NPCs as their scripts were added an odd dialogue option that wasn't actually available.

[Jehlicka]

Magi Hold - time to do some clean up here.

For some reason I was convinced that this chunk was already finished (cleanup activities). I was wrong. Np, I'm back to do it. Since I do not recall this place as well as I would like to, I post here some hint links:
https://www.vgoemulator.net/archive/Ang ... ld_Dungeon
https://vanguard.fandom.com/wiki/Magi_Hold
https://www.vgoemulator.net/archive/Sil ... _Hold.html
https://www.youtube.com/watch?v=8YD-abTIF5Q

[Jehlicka]

General info:
- have to check/add/edit POIs in this chunk --ok
- there are no quests created for the dungeon - all the inside ones are for the 50+ lvls, not scripted atm, anyway NPCs will have their scripts created with them. --ok

Clean up:
- Martok camp near the northern beach --done
- Martok Raiders camp - eastern chunk side beach --done
- Chunk eastern side --done
- Thrakos Island --done
- forests and open areas --done
- Magi Hold dungeon --wip
-- area round MH entrance --done
-- room with questgivers --done
-- flame part of dungeon --done
-- ice part of dungeon --done
-- arcena part of dungeon --wip
- House of Shaof + surroundings --done
- sea and beaches --done


Quest testing/findings:
Quest ID Quest Name
  2694 The Dragon's Bite --ok
  2702 A Force of Will
  4004 Martok Outrigger Amulets --ok
  4053 The Sick Recruit --ok
  4058 The Hills Are Alive (8 Enraged Undergrowths) -ok
  4059 Objects for Study --ok
  4060 Onward to Pao Min --ok
  4064 Savagery Must Be Contained --ok
  4065 How (Not) To Impress The Masters (10 Orc hands) --ok
  4116 Impress the Commander --ok
  4125 Proving Your Worth -ok
  4134 Cleaning Up --ok
  4135 Pride of the Army --ok
  4137 Short Handed Nakai --ok
  4142 Onward and Upward --wip
  4252 Kill the Coward --ok
  4880 Gathering the Cure --ok
  4881 The Cure --ok
  8757 A Soldier's Job --ok
  8758 Defend the House of Shaof --ok


Harvesting:
- harvesting reousources (trees, nodes, etc) need to be combined --done
- harvestable mobs added:
Enraged Undergrowth --done
Forest Tracker --done

NPCs:
Magi Hold dungeon:
- Hanai Amberwolf (Imperial Guard Captain) --created
- Jodin Skydragon (Imperial Magi) --created
- Imperial Soldier - IIRC, this NPC (spawn_id: 240175) was following you/part of the quest, set its spawn chance to 0 --done
- Naji Sevenblade (Imperial Officer) questgiver for higher lvl, maybe I can return to this script an dmake more greeting options --created
- Tanaja Ironwater (Naji's Assistant) --created
- Shou Kai Skyfall (Naji's Assistant) --provides many quests which are not scripted yet (higher lvl) --created
- Tensho Starwind (Imperial Officer) --tbd
- Magi Taysho --created
- Imperial Guard (multiple spawns probably---???) --tbd
- Menni Graystone (Suspicious Character) - Dialog Generator offers just greeting text, imho this NPC should be part of the quest --created
- Enslaved Tanvu Peasant --wip
Hidden tunnel - should be part of the quest Quest ID: 90404 Enter the Magi Hold barracks. --created without that quest function
Zosun (Commander of Magi Hold) - based on the quest text he should be located in the furnace room. Staying there all the time??? --created just greetings without the quest dialogs

Jale the Ulvari (The Possesor) --tbd - he hes two spawn location, dunno if he should be located next to eaxh Djinn, or maybe he should be set as is_unique 1 https://www.vgoemulator.net/archive/Ang ... the_Ulvari ???
Flame Djinn Essence of Fire --tbd
Iced Djinn Essence of Water --tbd
Lightning Djinn Essence of Electricity --tbd
Kensu --tbd
Denske --tbd, probably need to recreate this NPC, no Db record; the only info found: http://thetelonproject.wikidot.com/mobs:denske. I am not able to do it.
Moonsu The Undead General --tbd
Rekai Whitetalon --scripted
Arch Magus Shendu --tbd
Belzane the Arch Fiend --tbd
Masuke Whitewind --tbd
Devastator War Golem --tbd
Lost Experiment --tbd
...


Other areas:
- Lao!Jin Spirit (multiple spawns, but still NPCs) --created
- Imperial Recruit Koji (edit) --edited
- Great Statue Arakorr (purpose?) --tbd

Mobs/nameds:
- Officer Karaji has no weapon equipped --fixed
- There are some Jin'Ka Flyers, found some stuck in the rock (id 74900 and 74903), have to check their loc and purpose --tbd

[Jehlicka]

This is note for me to do not forget the objectives of the 50+ lvl quests during the MH cleanup. Also, pls start read here, if you are working on MH quests.

Magi Hold: Introduction: Speak to Naji --ok, she is scripted atm

For the Empire: Imperials Defeated 100 --ok, there is enough of them

Magi Magic: Collect twenty-five spell components from Magi's Hold --dunno if these items are available; Imperial Magi mobs have no such a script

Reverse Requistion: Collect twenty-five pieces of Imperial equipment from Magi's Hold --dtto

No More Golems: Collect twenty-five golem fragments from Magi's Hold --dtto (five types of the golems)

Magi Hold: Breaking Out - Defeat members of the Imperial Guard until information about Officer Rekai is found (Officer Rekai's Report) --dunno exact loc of the Officer and spawn conditions - spawned based on the quest item Report?

Magi Hold: Thinning the Herd: Defeat five Imperial war golems in Magi Hold --ok, they are up

The Karaji problem: Defeat Officer Karaji in the Magi Hold furnace room --officer Karaji is up, placed to move round the furnace (lower lvl)

Colorful Death: Defeat the prismatic war golem in the Magi Hold furnace room --this named is up, ok

The Arrogance of Xo: Defeat Head Researcher Xo in the Magi Hold furnace room --he is up, ok

Elemental Hazard: Collect twenty-five elemental shards from Magi's Hold --four types of elementals are up, but not scripted to drop any item. Also, only 18 up, need to create some more.

Magi Hold: General Strike: Rescue the captive workers inside Magi Hold --they are up (Enslaved Tanvu Peasant), but have just basic scripts (greeting, animation)

Magi Hold: Rekai Appears!: Confront (defeat) Rekai Whitetalon. Find Rekai near the clay warrior furnaces in Magi Hold. --based on this quest Magi Hold: The Hunt id_8605 the NPC Rekai should be up after handing that quest over to Naji. Afterthat Rkai spawns.
- Proper POI must be created, but the NPC is set to spawn_chance 0 for now.

Magi Hold: The Hunt:: Search Magi Hold for Officer Rekai. Search the three rooms where the three elementals are being kept, and return to Naji in Magi Hold. --ok, based on that, quest script should be scripted as "go to XYZ" in each room, Rekain will appear after hand over dialog.

Magi Hold Inferno: Defeat the flame ravager in the bottom floor of the halls leading to the flame djinn's prison --is set up

Magi Hold Deep Freeze: Defeat the hulking ice monstrosity --set as two spawns "is-unique:1" within two rooms, not combined.

Magi Hold Shock: Defeat Source of Arcane Energy --set as two spawns "is-unique:1" within two rooms, not combined.

Purge of the Elements: Defeat one hundred elemental shards and golems in Magi Hold --ok, they are all up

Magi Hold: Taking Down Rekai: Defeat Officer Rekai in Magi Hold --quest text says "she's barking orders in the golem furnace room"; dunno id this NPC should be already up all the time or based on event. Anyway, quest Magi Hold: Rekai Appears has the same goal....confusing!

The Ulvari and the War Golem: Confront the ulvari mage who was once Arch Magus Shendu and take back the giant war golem's device back (Defeat Arch Magus Shendu) --this NPC is located within Tomb of Lord Tsang and is not scripted yet.

The Rogue Fiend: Defeat Belzane the Arch Fiend --this NPC is located within Blighted Lands and is not scripted yet.

A Man of War: Defeat the legendary Imperial warrior Masuke Whitewind -- this NPC is located on the hill (east of the Magi Hold chunk) and is not scripted yet.

Weapon of Mass Destruction: Defeat the Imperial Devastator War Golem --NPC located within the chunk Sea of Kojan 208, not scripted

Denske & Kensu: Defeat Denske and her minion Kensu --did not find any NPC/named Denske in our Database! Probably not recorded. Kensu is up, not sripted yet tho.
In here, tehre is no such a quest like this: https://vanguard.fandom.com/wiki/Magi_H ... g_Timeline
Also, found the quest Denske's Alchemy Lab id 8641 within Bordinar's cleft, not scripted tho.

The Undead General: Defeat the undead warrior General Moonsu --NPC is up, just placeholder script created

Experiment Lost: Defeat the lost experiment outside of Magi Hold --NPC is up, not scripted

Magi Hold: Magi Hold Chaos: Speak to Naji Sevenblade in Magi Hold about Zosun. After speaking to Naji, follow her instructions on retrieving documents from Magi Hold sorcerers and from searching the Hold itself
Speak to Naji Sevenblade --up and scripted
Ritual Spell Scroll (1) --item id 1432034 not scripted
Magi Orders (1) --item id 1432035 not scripted
Spell Component List (1) --item id 1432036 not scripted
Damaged Letter (1) ----item id 1432037 not scripted


...tbc...