Bug 492: (zippyzee) When using the

[BugTracker]

Bug ID       : 492 - When using the  
Bug Date     : 2016/04/12 11:11:03
Assigned To  : zippyzee
Priority     : Low

Category     : VGClient
Sub-Category : Gameplay: Inventory
Severity     : Minor (e.g. Cosmetic)
Reproducible : Every time

Details:
When using the "Loot All" button to loot an item that was added via Lua in a mob's death() function, do not get the "You have looted ..." message in chat. Right-clicking the item in the loot window does trigger the message as expected.

Originated From World: New Telon (1)
Chunk                : Lomshir (68)
Location             : -38657 9576 10689

[Xinux]

You do get a link for the second item if there is more then one item in the loot window.

[zippyzee]

Mental note to remember to look at this. I'm getting pretty scattered on Vanguard systems right now but will get to it.

[Xinux]

This should be fixed in the next update.


In void Loot::ClientLootItem(shared_ptr<Client>& client, PacketStruct *packet, bool loot_all) I had to change the following.

Code: Select all

			if ((out = packet_struct_list.GetPacketStruct2Server("WS_ServerLootListUpdate")) == NULL){
				LogError(LOG_CHUNK, 0, "Loot::ClientLootItem: %s:%u", __FILE__, __LINE__);
				delete out;
				return;
			}
			LogDebug(LOG_ITEM, 0, "Loot::ClientLootItem: Removing unique id %u from loot window.", unique_id);
			out->SetUInt32("unique_id", unique_id);

			// This seems to always be set to 1
			out->SetUInt8("unknown1", 1);

			client->QueuePacket(out->Serialize());

			delete out;

To this cause on loot all we were not sending the unique_id when loot all button was used

Code: Select all

			if ((out = packet_struct_list.GetPacketStruct2Server("WS_ServerLootListUpdate")) == NULL){
				LogError(LOG_CHUNK, 0, "Loot::ClientLootItem: %s:%u", __FILE__, __LINE__);
				delete out;
				return;
			}
			LogDebug(LOG_ITEM, 0, "Loot::ClientLootItem: Removing unique id %u from loot window.", unique_id);

         if (unique_id != 0) {
			out->SetUInt32("unique_id", unique_id);
         {
         else {
         out->SetUInt32("unique_id", pawn_item->unique_id);
         }

			// This seems to always be set to 1
			out->SetUInt8("unknown1", 1);

			client->QueuePacket(out->Serialize());

			delete out;

[zippyzee]

Thanks Xinux!