Bug 493: (zippyzee) When turning the quest in

[BugTracker]

Bug ID       : 493 - When turning the quest in  
Bug Date     : 2016/04/12 07:55:51
Assigned To  : zippyzee
Priority     : Low

Category     : VGClient
Sub-Category : Gameplay: Quest
Severity     : Standard
Reproducible : Every time

Details:
When turning the quest in "Ancient Ksaravi Tome" QuestId 1146, the "Complete" button will not close the dialogue window, although the quest does get completed. Also, when accepting the follow-on quest, "Translated Ancient Ksaravi Tome" QuestID 1147, the "Accept" button does not close the dialogue box, but the quest does get accepted (both quests begin with an item click). Also, turning in the origional quest causes your character to enter combat. Xinux did some trouble shooting but requested that i bug report this.

Originated From World: New Telon (1)
Chunk                : Khal (85)
Location             : 56957 -90932 10498

[zippyzee]

Fortunately, some of this will get fixed with what I am working on right now.

Unknown6 in the quest database controls the actions after a character accepts a quest. It looks like it is set incorrectly for that quest. When unknown6 is set to 1, the dialog window automatically closes. When set to 0, it tries to continue a dialog, and doesn't close.

Unknown6 also controls the actions when completing a quest. At some point we will have to create two separate variables for each activity and set the behavior in the database.

Due to something else I'm working on, I'm adding a check to override the value if the character is not in a dialog to force closure. But at some point I will have to revisit this and make some final decisions.

The other quest issues I'll have to look at.

[Xinux]

I can add unknown6 to the DBE what do you want me to call it and i need a brief description for each value so i can make a dropdown for it.

[zippyzee]

Let me look at it a bit more and I'll get back with you. I also failed on my attempt to know if a character is in dialog--when you enter the quest display you are no longer in the active dialog list so that idea did not work. I have some changes that will go up very soon and then I'll look at this again.

[Xinux]

K is this still kinda true for unknown7a also?

Code: Select all

Struct value for unknown6 seems to be for : decline action (when you click on button "decline") : value:0 = back to the hail function, value:1 = close the dialog window.

Struct value for unknown7a is the same thing but for the complete action (when you click on button "complete") : values are not yet determined.

[zippyzee]

Not exactly for unknown7a. I don't think I am using the database value at all, but setting it internally. The values are all over the place in the logs and I haven't made sense of them yet.

Unknown6 could probably be called close_dialog, or close_after_accept. When it is 0, the dialog npc is re-hailed. When it is 1, it is closed after accept.

[Valorith]

Is there any variable that will make you enter combat on complete? Because that is happening.

[zippyzee]

We are about to find out! I'm excited about this bug.

[Valorith]

Its ironic, because this NPC is supposed to attack you on complete (you then loot a quest item off him to start the next quest). I don't know if this behavior (entering combat on complete) is related to the original desire for the quest or if it is just a coincidence. It needs to be noted that the Player is the one entering combat on complete, not the NPC. Just throwin that out there.

[zippyzee]

Looking at the database entry, the only unusual values are for quest_difficulty (1) and location_count (1). I don't see anything else amiss. I will probably not have any time until tomorrow to dig deeper, unfortunately.