Bug 152: (Faux) Players who are in Guilds that...

[John Adams]

Apparently this bug still exists. Seeing it in the console log now, Shargash and I are spamming a ton of offline guildmates

[Faux]

Ok, I'll tackle this next.

[Faux]

I moved the code to update the guildmember struct from camptimers.cpp (where it had no business being) to its own routine in guild.cpp (MemberDisconnect). This MemberDisconnect routine gets called now by the chunk_server->DisconnectChunkClient() routine, which handles the cases of a normal camp out and a dev/GM bypassing the camp timer.

I thought it would cover the "force quit" scenario as well, but it doesn't. I have to find out how our code handles a client that has been force quit to take care of this.

Alternately, someone had mentioned an issue where guildmates rifting were not getting updated in the UI. I noticed that parts of HandleClientAuthConfirm had been rewritten, including making SendGuildPCInfo a "one time sent" packet. That packet has to be sent at every chunk/rift in order to keep the guild ui up to date. I commented out that line so it sends every time and the problem resolved.

Edit: This should partially alleviate any spamming of the console for offline guild members. The rest should clear up when I handle the force quit scenario. From an efficiency standpoint, I may implement a comparison for guild size and players online. If guild size is smaller, the member list will be iterated for sending the message. If players online is smaller, the character list will be checked instead.