Page 2 of 2

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Mon Jul 11, 2016 3:45 pm
by Jakkal
Okay, I remember why we didn't put the quest rewards on this one. All the gear items on IOD were limited to class. For example, the "Rake's Battleblade" was the rogue only quest reward for the IOD quest: Living On A Prayer. Anything with "rake" in the name was only given to rogues. But the item itself shows that it's usable by all dagger-using classes.

Currently, if I understand this right, the DBE lets us set up the rewards, but the rewards show up for anyone of a capable class. So the rake's Battleblade will show up as an option for any dagger capable class that does the quest. This quest on the bug report is an archetype training quest, but further on, there are quests (Such as "Living on a prayer") that all classes have to do.

So, this needs to be done for rogue only. But do we really need to make 11 versions of every quest on the IOD to make sure the rewards only go to the specific class?

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Mon Jul 11, 2016 3:55 pm
by zippyzee
We don't make any extra versions of any quests. All the quests that we have are from the logs. Even those silly archetype specific quests all had 4 versions in the logs.

If you have a class-specific item, then it should only show as a reward to players of that class. Are you saying that the item is not specific to just that class, and other people are seeing it, or that it is not working as intended and players of other classes are being offered it?

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Mon Jul 11, 2016 5:02 pm
by Jakkal
In the live game, the screenshots of it show being available to other classes:
[img]http://thetelonproject.wdfiles.com/loca ... /small.jpg[/img]

But in game, it was only available for rogues to take.

But the way our current stuff is set up, anyone that's on that list of available classes sees it as a possible reward.

For example, if I'm playing a Sorcerer, this should be the only item I'm supposed to get from "Living on a Prayer":
[img]http://thetelonproject.wdfiles.com/loca ... Battle.png[/img]

But when a sorcerer completes the quest, they'll see all of these:
Channeler's Staff of Battle (Sorc reward)
Rake's Battleblade (Rogue Reward)
Occultist's Staff of Battle (Necro reward)
Whatever the Druid Staff is

But the Sorc should *only* be offered the Channel's stuff.
The rogue should *only* be offered the Rake stuff.
The Necro should *only* be offered the Occultist's stuff.

Right now if you have a quest reward that has your class on it, it gets offered, even if it's not supposed to. So we need to be able to limit the rewards based on certain factors like class.

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Mon Jul 11, 2016 5:21 pm
by zippyzee
We'll have to conside a strategy on this. We will have to have some variable to control this. We have the added issue that there are quest rewards that you should see even if you can't use it on some quests. Here, we could just change the usable class on the item to the specific quest, but I don't like that idea.

We might have to have a class bitmask for each reward as an additional variable. We set it to the item class bitmask initially, and then allow adjustment in the database. The code can then use that to determine what to show rather than the item bitmask. Any other ideas?

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Mon Jul 11, 2016 6:02 pm
by Xinux
Personally I say if it is usable by the class then give them the option to select which one they want but that is just my opinion and not like live was.

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Thu Jul 14, 2016 7:31 pm
by shargash
I submitted the original bug report. When my DK went to the quest giver, I was offered only rogue weapons -- a long and a short sword. This is appropriate for a rogue, but since DK's can't dual wield, it was kind of silly. I should have been offered a 2H weapon (since DKs have abilities that work only with 2H weapons), but that was not an option.

Now, if the easiest way to implement rewards is to offer me everything I can use, I'm fine with that. I will just pick the one that is appropriate. But in this case, I was
not offered a choice, just the rogue weapons, which were really inappropriate for the DK.

Re: Bug 639: (Content) I just created a new DK. When ...

Posted: Thu Jul 14, 2016 7:36 pm
by Jakkal
We haven't set up the rewards for any of the quests other than what was already in the DBE. The reason that sword is there is related to some things John and I were messing with way back in December, when we were trying to figure out how to make the "Go Train" quests work with the proper archetype. At the time, that was the only weapon set listed for the quest (Because of whoever went through to get the data, I assume). So I think those rewards were stuck on all those quests.

We haven't gone through quest rewards to fix it, notably because of the issues we discussed above.

This is why on my Dahknarg thread, I posted that quests work, quest rewards have not gotten a pass.