New Client on Test with UI performance fixes

I just updated Test server with a new client that contains performance updates and I need help testing it. Basically, this was a significant low level change to the UI to optimize how components of the UI are referenced. This change could have had an effect on Custom UI's as the naming of windows is now CASE SENSITIVE!!

Please login to test and let me know if you run into any issues. If the common VG UI Mods break horribly, I can put the case insensitivity for window lookups back.
Btw, a comparison I did was I applied more buffs to my character than an average raid player will have. And then I stripped them all off. Sometimes, this would cause my client to lockup for 10-15s as it removed all the buffs. Now this takes a fraction of a second.

Anyways, I'll be on Test off and on today if you have specific questions you would like to ask.

Hooray, will jump on when I get home, though that's a good 10 hours away

am on test, cant open any bags , cant rift. not sure what else to check, using default UI and infomap

Wow, Case Sensitive will definitely impact ALL UIs is my guess.

we were able to rift by using /rift khal or /rift ahgram no perceptible lag on leavwar even with full buff load. but still cant open bags, or see rift maps (even with infomap disabled)

Checking

I can open my bags on Test. Are you using the B key or right clicking?

Should the launchpad have updated any of the default Ui files when swapping to Test for this? Didn't seem to, and I'm having a few issues also with windows. Though I'm using VNC to run it on my PC from home, so that may be why I'm having a few troubles.. I'll give it a proper go later this evening.

Hobart wrote:

clicking. the only bag that opens is main inventory

Ok, I deleted my default UI folder and now it seems to work fine.

good to hear, ive been brainstormimg for a week now how i could upgrade droxs performance. came up with a few that ill have to try.
anyway ill test this friday when ill get home

I have the window not showing issue fixed locally.
Checking out the bag issue now.

Exxcellent

I think I have all the major issues fixed. I'll be updating Test shortly. Please let me know if you see anything else broken. Again, the UI lookups are still CASE SENSITIVE!!! I can still change this if needed.

Hobart wrote:

For curiosities sake, is the case sensitivity change in any way impacting on the performance, or is it really just for consistency/best practices that you've changed this?

Hobart wrote:

i checked after raid (about 8pm) still no rift map and cant open bags, will check again in the morning.

Test is updating now.

Case sensitivity really does have an impact on the performance. In every case in the UI, when you want to display something, a search is being done on that window name or search key. The old way, it would do a string insensitive string compare(Super expensive to do) to see if it found the right window. This means that each character on the source string and the comparison string had to be changed either toUpper or ToLower. Basically, you have to change each character which means looping over each character in the string.

Now all the UI windows and components are stored in a hash table by their name. So when inserting and finding, we hash the string name just once. This is way more efficient than the previous method of searching.
However, I'm not doing the toUpper or toLower before inserting in the hash table or before finding the window by name. Saving a little performance. However, if this breaks custom UI's pretty bad, I'm sure I can put the case insensitivity back and look for performance savings in other locations.

Hobart wrote:

Makes sense, thanks. Personally I'd think it best to keep it case sensitive, even if it means custom UIs need to be tidied up a little for whenever this change goes live. It's not like we haven't had dozens of previous udpates that required custom Ui updates to keep them working
As long as there's consistency with the capitalization format, hehe. Assuming so, can you confirm what format you've gone with, please?

No UI xml has been changed. What is on Live or Test is how it will be. Assuming that custom UI's use the existing names, for the search key and window name portion of the UI elements, there should be no issues.
Everything right now is pretty much all lower case.

Sweet, thank you

I logged on with my main character Kilsin, using DroxyCore UI (mix of Drox and CoreUI3) and had no problems at all, very smooth, although it was only Khabs and myself on the entire server, I am sure that will change under load.
The rain looks pretty good too! nice job
One thing I did notice, when I logged in under my Cleric to test a bit of Crafting, I was opening a heap of bags from Work Orders and nearly everything was a "You are first to Discover this Item".
So far it seems to be a nice upgrade, I can't wait to test it under raid conditions.